Skip to content

Mobile touch events to work on leaflet 1.7#185

Open
makeus wants to merge 2 commits intoWildhoney:masterfrom
makeus:master
Open

Mobile touch events to work on leaflet 1.7#185
makeus wants to merge 2 commits intoWildhoney:masterfrom
makeus:master

Conversation

@makeus
Copy link

@makeus makeus commented Apr 8, 2022

Description

Fixes problem with map.on('touch') events not working on leaflet >= 1.7 by changing the code to use L.DomEvent instead.

Fixes issues

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested drawing on leaflet 1.7.1 and leaflet 1.5.1

Desktop (default and mobile touch simulation)

  • Chrome 99.0.
  • Firefox 98.0

Mobile

  • Android 12 Firefox 99.1 and Chrome 100.0
  • iOS 15.0 Safari

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@stell
Copy link

stell commented May 28, 2022

What can we do to get this project going? Polygon display is also causing trouble. Is FreeDraw dead or can someone take over?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants