Skip to content

add open and close animations#487

Draft
WillPower3309 wants to merge 12 commits intomasterfrom
open-close-animations
Draft

add open and close animations#487
WillPower3309 wants to merge 12 commits intomasterfrom
open-close-animations

Conversation

@WillPower3309
Copy link
Owner

@WillPower3309 WillPower3309 commented Jan 10, 2026

  • fade in
  • fade out

@WillPower3309 WillPower3309 marked this pull request as draft January 10, 2026 23:44
@WillPower3309 WillPower3309 changed the title addopen and close animations add open and close animations Jan 10, 2026
@georglauterbach
Copy link
Contributor

Animations would be very nice! Anything we can do to support you? Maybe testing?

@WillPower3309
Copy link
Owner Author

Animations would be very nice! Anything we can do to support you? Maybe testing?

if you'd like animations in general, they're currently in the git release. As for open and close specifically no worries, they should be merged soon

@georglauterbach
Copy link
Contributor

georglauterbach commented Feb 7, 2026

That's quite interesting, as I'm building from source already. I must have missed the animations somehow - can you give me a clue where to find the settings? Thanks! :)

EDIT: I've found animation_duration_ms and played around with it a bit, but I couldn't get it to work. What exactly is it for? Nevermind, built the wrong version.

UPDATE: I tested the animations and they look nice! Looking forward to having the fade as well - great job! 🚀

@WillPower3309
Copy link
Owner Author

That's quite interesting, as I'm building from source already. I must have missed the animations somehow - can you give me a clue where to find the settings? Thanks! :)

EDIT: I've found animation_duration_ms and played around with it a bit, but I couldn't get it to work. What exactly is it for? Nevermind, built the wrong version.

UPDATE: I tested the animations and they look nice! Looking forward to having the fade as well - great job! 🚀

I'll update the readme to make it more clear to others! Thanks, I'm glad to hear you've been liking them!

@WillPower3309
Copy link
Owner Author

Current appearance, want them to pop in an out as well

2026-02-08.03-15-44.mp4

@georglauterbach
Copy link
Contributor

Looks awesome! I would like to report two "inconveniences" that I found while running the latest version. If you want me to, I can also open a new issue so that we do not make this PR discussion bigger than necessary:

  1. When opening a second window with smart_gaps on, the gap in the middle is added at the very end, which can be observed well when using a long animation duration. Take a look at the gap in the middle of the screen that appears at the end:

    screenrecord.mp4

    This will probably be less visible with the fade animations?

  2. In the video you posted, it looks as if the first window is scaled to the full width of the screen right when the second window is opened and then the first windows is scaled to half of the screen width. This will, only shortly but still visibly, stretch the contents of the first window. Is this intended, and do you think this can be solved?

@WillPower3309
Copy link
Owner Author

WillPower3309 commented Feb 10, 2026

Need to look into view_autoconfigure() logic to assess the content_width and content_height setting (given the changes in arrange.c)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants