Added global lock to linux wg quick, fixed race condition when 2 wg interfaces wanted to have the same table number#23
Open
andrew-aladjev wants to merge 1 commit intoWireGuard:masterfrom
Conversation
andrew-aladjev
force-pushed
the
master
branch
2 times, most recently
from
db2341a to
5050316
Compare
…nterfaces wanted to have the same table number. 1. You are creating multiple wg interfaces and starting them in parallel. 2. All wg interfaces is trying to use table number 51820. 3. The first wg interface succeeds, other interfaces fail. What is the problem in wg quick? It is not globaly locking calculation of next table number. How to fix it? We need to add global flock. Signed-off-by: Andrew Aladjev <andrew.aladjev@protonmail.com>
zx2c4-bot
force-pushed
the
master
branch
2 times, most recently
from
4574b8e to
0b7d982
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added global lock to linux wg quick, fixed race condition when 2 wg interfaces wanted to have the same table number.
If it will be accepted than the next step will be to separate adding default route and adding firewall rules.
What issue has been fixed:
What is the problem in wg quick? It is not globaly locking calculation of next table number.
How to fix it? We need to add global flock.