refactor: move @property rules outside :root #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
severinlandolt
force-pushed
the
severin/property-top-rule
branch
from
d52904e to
7eb0301
Compare
- Move @Property declarations to top level instead of nested in :root - Add .prettierrc with prettier-plugin-tailwindcss - Update prettier to 3.7.4 and add prettier-plugin-tailwindcss - Reformat tw-animate.css with Prettier
severinlandolt
force-pushed
the
severin/property-top-rule
branch
from
7eb0301 to
8e356c2
Compare
Owner
|
Hey there, do you think it's better to move the prettier configuration currently present in |
Author
|
Strong YES! |
Author
|
@Wombosvideo Let's merge! |
Owner
|
Sorry, didn't see your other reply. Could you move the package.json values to the extra file? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@propertydeclarations from:rootto top-level scope to prevent inheritance issues Cannot use @property rules within :root{} pseudo classes #61