Add example with Orthographic rendering#35
Open
sorskoot wants to merge 1 commit intoWonderlandEngine:mainfrom
Open
Add example with Orthographic rendering#35sorskoot wants to merge 1 commit intoWonderlandEngine:mainfrom
sorskoot wants to merge 1 commit intoWonderlandEngine:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a new example demonstrating React UI integration with orthographic rendering mode. The example shows how to properly configure pipelines to ensure UI elements render correctly on top of other scene objects when using orthographic projection.
- Adds orthographic rendering example with modified depth pipeline configurations
- Includes both screen-space and world-space UI demonstrations
- Adds build script support for development with source maps and watch mode
Reviewed Changes
Copilot reviewed 7 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/react-ui/package.json | Adds development build script with watch and source map support |
| examples/example_orthographic/tsconfig.json | TypeScript configuration for the new orthographic example |
| examples/example_orthographic/package.json | Package configuration and dependencies for orthographic example |
| examples/example_orthographic/js/react-ui.tsx | React UI component implementation demonstrating UI elements in orthographic mode |
| examples/example_orthographic/js/index.js | Auto-generated Wonderland Engine entry point for the example |
| examples/example_orthographic/cache/packagejson.hash | Package dependency hash file for caching |
| examples/example_orthographic/ReactUi_example_orthographic.wlp | Wonderland Engine project configuration with orthographic camera and UI pipeline settings |
Files not reviewed (1)
- examples/example_orthographic/package-lock.json: Language not supported
Collaborator
|
Might it make sense to just add the new project file to the other example? Then we wouldn't need to duplicate the static assets / images, nor the react-ui.tsx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add example of UI in orthographic rendering mode
Main difference is the way the pipelines are set up to make sure the UI is rendered on top.
Note: Due to a bug in the Cursor Component (issue 77) the target is not selected correctly.