Default all initial suggested results to 20 for navigation link ui#75186
Merged
Default all initial suggested results to 20 for navigation link ui#75186
Conversation
jeryj
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +10 B (0%) Total Size: 2.99 MB
ℹ️ View Unchanged
|
getdave
approved these changes
Feb 4, 2026
Contributor
getdave
left a comment
getdave
left a comment
There was a problem hiding this comment.
Looks like a reasonable change. Thanks!
Comment on lines
42
to
55
| case 'page': | ||
| return { type: 'post', subtype: type }; | ||
| return { type: 'post', subtype: type, perPage: 20 }; | ||
| case 'category': | ||
| return { type: 'term', subtype: 'category' }; | ||
| return { type: 'term', subtype: 'category', perPage: 20 }; | ||
| case 'tag': | ||
| return { type: 'term', subtype: 'post_tag' }; | ||
| return { type: 'term', subtype: 'post_tag', perPage: 20 }; | ||
| case 'post_format': | ||
| return { type: 'post-format' }; | ||
| return { type: 'post-format', perPage: 20 }; | ||
| default: | ||
| if ( kind === 'taxonomy' ) { | ||
| return { type: 'term', subtype: type }; | ||
| return { type: 'term', subtype: type, perPage: 20 }; | ||
| } | ||
| if ( kind === 'post-type' ) { | ||
| return { type: 'post', subtype: type }; | ||
| return { type: 'post', subtype: type, perPage: 20 }; |
Contributor
There was a problem hiding this comment.
Let's just use a constant value then?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #68185
Defaults initial suggested results to 20 instead of 3.
Why?
Consistency across components. The inline link editor has more than 3 default suggested results as well.
How?
Increase navigation link ui suggestion queries to 20 instead of letting them default to 3.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Before
Screen.Recording.2026-02-03.at.1.33.24.PM.mov
After
Screen.Recording.2026-02-03.at.1.33.00.PM.mov