Add test for block template name validation with underscores#8207
Add test for block template name validation with underscores#8207Sukhendu2002 wants to merge 6 commits intoWordPress:trunkfrom
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
felixarntz
left a comment
There was a problem hiding this comment.
@Sukhendu2002 Thank you for the PR! The test looks good, however instead of creating a new test class for it, it would be better to use the existing class for that purpose.
|
Hey @felixarntz, Thanks for the review! I have moved the test to the existing test file. Take a look when you get a chance. Thanks! |
felixarntz
left a comment
There was a problem hiding this comment.
@Sukhendu2002 Thank you for the updates, this looks great. Just one last point of feedback, then this should be good to commit.
tests/phpunit/tests/block-templates/WpBlockTemplatesRegistry.php
Outdated
Show resolved
Hide resolved
felixarntz
left a comment
There was a problem hiding this comment.
Thanks @Sukhendu2002, LGTM!
Trac ticket: https://core.trac.wordpress.org/ticket/62523
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.