Skip to content

Tests: Add unit test for pagination trailing slash#8226

Closed
Infinite-Null wants to merge 7 commits intoWordPress:trunkfrom
Infinite-Null:add/pagination-trailing-slash-test
Closed

Tests: Add unit test for pagination trailing slash#8226
Infinite-Null wants to merge 7 commits intoWordPress:trunkfrom
Infinite-Null:add/pagination-trailing-slash-test

Conversation

@Infinite-Null
Copy link

@Infinite-Null Infinite-Null commented Jan 31, 2025

Trac ticket: #61393

Description

Adds a unit test to verify pagination links maintain consistent trailing slash behavior when the permalink structure has trailing slash as well as does not have trailing slash.

Testing instructions

  1. Run the unit test:
npm run test:php -- --filter=Tests_General_PaginateLinks

@github-actions
Copy link

github-actions bot commented Jan 31, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props ankitkumarshah, audrasjb, sourabhjain.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@Infinite-Null Infinite-Null marked this pull request as draft January 31, 2025 00:52
$link = add_query_arg( $add_args, $link );
}
$link .= $args['add_fragment'];
$link = get_option( 'permalink_structure' ) ? user_trailingslashit( $link ) : $link;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the implementation to address the failing test cases.

@Infinite-Null Infinite-Null marked this pull request as ready for review January 31, 2025 02:04
@Sourabh208
Copy link

QA Report:

Issue is fixed.

Twenty Five
Screenshot 2025-02-27 at 18 39 20

Screenshot 2025-02-27 at 18 39 29

Astra

Screenshot 2025-02-27 at 18 45 26 Screenshot 2025-02-27 at 18 45 37

@Infinite-Null
Copy link
Author

Merged in the changeset [59966]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants