Added window insets to respect system bars, especially for full screen overlays#178
Open
EvertJanDeBruin wants to merge 2 commits intoX-SLAYER:mainfrom
Open
Added window insets to respect system bars, especially for full screen overlays#178EvertJanDeBruin wants to merge 2 commits intoX-SLAYER:mainfrom
EvertJanDeBruin wants to merge 2 commits intoX-SLAYER:mainfrom
Conversation
…ts (statusbar, navigationbar etc) should be respected by the overlay. This is especially needed for full screen overlays, which tended to take up more than the whole screen (overflow out of bounds).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced Window Insets, where user of library can select which insets (statusbar, navigationbar etc) should be respected by the overlay. This is especially needed for full screen overlays, which tended to take up more than the whole screen (overflow out of bounds).
I also did a tiny bit of refactoring around setting the initial position and moving the overlay, which seemed to be buggy.