xf86bigfont: add comment on including fontstruct.h#1941
Open
Conversation
stefan11111
reviewed
Feb 4, 2026
| #include <X11/Xproto.h> | ||
| #include <X11/extensions/xf86bigfproto.h> | ||
| #include <X11/fonts/fontstruct.h> | ||
| #include <X11/fonts/fontstruct.h> // libxfont2.h missed to include that |
Contributor
There was a problem hiding this comment.
Isn't this just a comment change? How does this fix compilation?
Also, can you use a C-style comment?
Contributor
Author
There was a problem hiding this comment.
Indeed. That's been coming from an older queue which I've just rebased again.
Probably the actual fix had already landed.
Contributor
Author
There was a problem hiding this comment.
updated commit and PR description
Document that this particular include is just a workaround for a bug in libxfont2.h, which forgot to include this header. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
metux
force-pushed
the
pr/xf86bigfont-make-the-extension-compile-again-_2026-02-04_17-26-39
branch
from
79d2dbe to
f203f6b
Compare
metux
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document that this particular include is just a workaround for
a bug in libxfont2.h, which forgot to include this header.