Skip to content

Fix/159 windows theme#162

Merged
X9X0 merged 5 commits intomainfrom
fix/159-windows-theme
Dec 12, 2025
Merged

Fix/159 windows theme#162
X9X0 merged 5 commits intomainfrom
fix/159-windows-theme

Conversation

@X9X0
Copy link
Owner

@X9X0 X9X0 commented Dec 12, 2025

Problem: The "Connect to LabLink Server" dialog had hardcoded light theme styles (lines 20-53) that overrode the app-level theme
system.

Solution: Removed all inline setStyleSheet() calls from ConnectionDialog. The dialog now inherits the app-level theme properly.

Changes made:

  • Removed hardcoded background colors (#ecf0f1)
  • Removed hardcoded group box styles (white background, #bdc3c7 borders)
  • Removed hardcoded button colors (#3498db blue)
  • Dialog now uses theme-defined styles for all elements

Result: The connection dialog will now properly display in:

  • Light theme - Light backgrounds and colors
  • Dark theme - Dark backgrounds and colors
  • Auto theme - Medium contrast colors

X9X0 and others added 5 commits December 12, 2025 10:36
- Upgraded favicon.png from 32x32 to 128x128 pixels
- Regenerated icon.ico with multiple resolutions (16, 32, 48, 256)
- Used Splash.png (1024x1024) as high-quality source
- Added generate_icons.py script for future icon regeneration

This fixes blurry/pixelated desktop shortcut icons on Windows.
The multi-resolution .ico file ensures sharp display at all sizes,
especially on high-DPI displays.

Part of issue #159 improvements

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Processed lablink_multi.ico to remove black background
- Generated transparent favicon.png (128x128) with RGBA
- Created multi-resolution icon.ico with transparency
- Includes sizes: 16, 20, 24, 32, 40, 48, 64 for all display contexts
- Added process_icon_transparency.py script for future icon updates

Icons now have transparent backgrounds instead of black, making them
look professional on any desktop background color. Much sharper and
clearer than previous versions.

Part of issue #159 improvements

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Switched from 255x255 lablink_multi.ico to 1024x1024 Splash.png source
- Generated 10 icon sizes: 16, 20, 24, 32, 40, 48, 64, 96, 128, 256
- Added 256x256 size critical for Windows 11 high-DPI displays
- Used LANCZOS resampling for highest quality downscaling
- All icons have transparent backgrounds (RGBA)

Starting from a 4x larger source image (1024px vs 255px) produces
significantly sharper icons with better edge quality, especially
noticeable on high-DPI Windows 11 displays.

The icon should now appear crystal clear on the desktop.

Part of issue #159 improvements

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Added LL.png as logo-only source (357x358, no text)
- Regenerated all icon sizes from LL.png
- Icons now show only the LS logo symbol without "LabLink" text
- Multi-resolution icon.ico: 16, 20, 24, 32, 40, 48, 64, 96, 128, 256
- All sizes with transparent backgrounds (RGBA)
- favicon.png updated to 128x128 logo-only version

Desktop shortcuts now display just the clean logo symbol without
any text, which is the proper icon design for Windows shortcuts.

Added generate_final_icons.py for future icon regeneration.

Part of issue #159 improvements

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Removed inline setStyleSheet from ConnectionDialog
- Dialog now properly inherits app-level theme
- Connection dialog will now respect Light/Dark/Auto theme selection

Previously the connection dialog had hardcoded light theme colors
that overrode the theme system, causing it to always appear in
light mode even when dark theme was selected.

Part of issue #159

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@X9X0 X9X0 merged commit baefc1e into main Dec 12, 2025
16 checks passed
@X9X0 X9X0 deleted the fix/159-windows-theme branch December 12, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant