Open
Conversation
gatecat
reviewed
May 22, 2023
ecp5/arch.cc
Outdated
| // --------------------------------------------------------------- | ||
|
|
||
| static const ChipInfoPOD *get_chip_info(ArchArgs::ArchArgsTypes chip) | ||
| static void get_chip_info(std::string device, const DeviceInfoPOD **device_info, const ChipInfoPOD **chip_info, const PackageInfoPOD **package_info, |
Member
There was a problem hiding this comment.
can you create a struct or something for all these fields rather than tons of ** arguments?
gatecat
reviewed
May 22, 2023
ecp5/arch.cc
Outdated
| *package_name = pkg.name.get(); | ||
| *device_name = chip.name.get(); | ||
| *type = Arch::ArchTypes::NONE; | ||
| if (strcmp(*device_name,"LFE5U-12F")==0 || strcmp(*device_name,"LAE5U-12F")==0) |
Member
There was a problem hiding this comment.
I would definitely prefer using C++ or Boost string stuff to the old C functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one also support old style command line parameters so no changes from user perspective.
Fixes parameters validation check and actually displaying the message