Open
Conversation
Member
|
Are these the changes made to the appnote? |
Contributor
Author
|
Yes! They should be https://yosyshq.readthedocs.io/projects/ap130/en/latest/ |
Comment on lines
+18
to
+19
| mode prep | ||
| skip_prep on |
Member
There was a problem hiding this comment.
Isn't that an oxymoron? Is it just running the user script and nothing else?
Comment on lines
+69
to
+73
| # Read the stage 1 checkpoint, and then use the stage 1 trace to simulate up | ||
| # to the end of stage 1. | ||
| # Note that, in stage 2, we do not use -noinitstate on sim, as this first | ||
| # simulation begins at t=0 and thus $initstate cells should be active. All | ||
| # future calls to sim should include -noinitstate. |
Member
There was a problem hiding this comment.
Are these comments an abbreviated version of the appnote text? Is the intention to update the appnote code to match? It feels like having extra comments here would make it harder to maintain the appnote if we change this (though if the comments also exist in the source for the appnote they are just hidden in the code render please ignore this 😄)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the reasons/motivation for this change?
We wanted to make the example more complex to cover more edge cases and root out more tricky behavior.
Explain how this is achieved.
Adds another stage in the middle, and combines the previous init and prove stages for each stage. This forced the addition of a new prep phase.