Resolved multiple -Wsign-compare warnings#3304
Draft
SAN4EZDREAMS wants to merge 10 commits intoZDoom:masterfrom
Draft
Resolved multiple -Wsign-compare warnings#3304SAN4EZDREAMS wants to merge 10 commits intoZDoom:masterfrom
SAN4EZDREAMS wants to merge 10 commits intoZDoom:masterfrom
Conversation
d4e503c to
7e6f1c5
Compare
Contributor
|
the fix to this isn't casting everywhere, that just hides the warnings, it's to change indices/etc to the proper sign where possible |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes numerous signed/unsigned comparison warnings reported by recent GCC versions across the code.
Changes involve explicit type casting to ensure safe comparisons without altering the original logic.
Exception (third-party library):