Skip to content

Conversation

@GaetanGrd
Copy link
Collaborator

Implementation

QOL for further future development

  • adding rigth click and middle click handling to close dropdown menu when you click outside menu.
  • adding props to show limited number of items in a menu

How to Test

  • npm i
  • Adding maxVisibleItems = x;" in bsm-dropdown-button.component.tsx`
  • npm start
  • Click on any version
  • Click on settings button for this version
  • See

Questions

  • How i can be remove "+8" in my calcul and conserv a "nice" result ?

Emoji Guide

For reviewers: Emojis can be added to comments to call out blocking versus non-blocking feedback.

E.g: Praise, minor suggestions, or clarifying questions that don’t block merging the PR.

🟢 Nice refactor!

🟡 Why was the default value removed?

E.g: Blocking feedback must be addressed before merging.

🔴 This change will break something important

Blocking 🔴 ❌ 🚨 RED
Non-blocking 🟡 💡 🤔 💭 Yellow, thinking, etc
Praise 🟢 💚 😍 👍 🙌 Green, hearts, positive emojis, etc

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@GaetanGrd GaetanGrd requested a review from Zagrios January 30, 2026 20:31
@GaetanGrd GaetanGrd changed the title Feature/better drop down button Feature/better-dropdown-button Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant