start basic h7 support#852
Conversation
- add GPIO N-K in common/gpio_v2 - move put,toggle and read func to from common/pins_v2 common/gpio_v2
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🔍 Lint Results
Found 9 issues on changed lines in 1 file:
- port/stmicro/stm32/src/hals/STM32H723/rcc.zig: 9 issues
ℹ️ Additional issues on unchanged lines
The following 20 issue(s) exist but are not on lines changed in this PR:
drivers/framework.zig:30: Suggestion: Rename `Keyboard_Matrix` to `KeyboardMatrix`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:31: Suggestion: Rename `Debounced_Button` to `DebouncedButton`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:32: Suggestion: Rename `Rotary_Encoder` to `RotaryEncoder`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:64: Suggestion: Rename `IO_expander` to `IO_Expander`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:76: Suggestion: Rename `Cyw43_Spi` to `CYW43_SPI`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:77: Suggestion: Rename `Cyw43_Bus` to `CYW43_Bus`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:78: Suggestion: Rename `Cyw43_Runner` to `CYW43_Runner`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:210: Suggestion: Rename `Datagram_Device` to `DatagramDevice`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:211: Suggestion: Rename `Stream_Device` to `StreamDevice`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:213: Suggestion: Rename `Clock_Device` to `ClockDevice`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:214: Suggestion: Rename `Block_Memory` to `BlockMemory`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/build.zig:18: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/generate.zig:272: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/pins_v2.zig:47: Suggestion: Rename `InputGPIO` to `Input_GPIO`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/pins_v2.zig:54: Suggestion: Rename `OutputGPIO` to `Output_GPIO`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/wch/ch32v/build.zig:3: Suggestion: Rename `CpuName` to `CPU_Name`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/wch/ch32v/build.zig:10: Suggestion: Rename `KiB` to `Ki_B`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/wch/ch32v/src/hals/clocks.zig:14: TODO style comments need to have a linked microzig issue on the same line.
port/wch/ch32v/src/hals/clocks.zig:158: TODO style comments need to have a linked microzig issue on the same line.
port/wch/ch32v/src/hals/clocks.zig:181: TODO style comments need to have a linked microzig issue on the same line.
| } | ||
| } | ||
|
|
||
| // TODO: maybe create a function to disable PLL dividers individually |
There was a problem hiding this comment.
TODO style comments need to have a linked microzig issue on the same line.
| } | ||
| } | ||
|
|
||
| // TODO: fix MMIO to include registers for PLL2 and PLL3 |
There was a problem hiding this comment.
TODO style comments need to have a linked microzig issue on the same line.
| return ms_per_tick * val; | ||
| } | ||
|
|
||
| //TODO: OTF, MDMA, USB_OTG_PHY, ETH_RC/TX |
There was a problem hiding this comment.
TODO style comments need to have a linked microzig issue on the same line.
| //clocktree type shortcuts | ||
| const ClockTree = @field(@import("ClockTree"), microzig.config.chip_name); | ||
| const Config = ClockTree.Config; | ||
| const Clock_Output = ClockTree.Clock_Output; |
There was a problem hiding this comment.
Suggestion: Rename Clock_Output to ClockOutput, it should be more in line with our style guidelines. This automation is not perfect so take it with a grain of salt.
| const ClockTree = @field(@import("ClockTree"), microzig.config.chip_name); | ||
| const Config = ClockTree.Config; | ||
| const Clock_Output = ClockTree.Clock_Output; | ||
| const Config_Output = ClockTree.Config_Output; |
There was a problem hiding this comment.
Suggestion: Rename Config_Output to ConfigOutput, it should be more in line with our style guidelines. This automation is not perfect so take it with a grain of salt.
| mco2_pre: MCOPRE, | ||
| }; | ||
|
|
||
| pub const Sysclk_Config = struct { |
There was a problem hiding this comment.
Suggestion: Rename Sysclk_Config to SysclkConfig, it should be more in line with our style guidelines. This automation is not perfect so take it with a grain of salt.
| clk_src: SW, | ||
| }; | ||
|
|
||
| pub const D1_Kernel_Config = struct { |
There was a problem hiding this comment.
Suggestion: Rename D1_Kernel_Config to D1_KernelConfig, it should be more in line with our style guidelines. This automation is not perfect so take it with a grain of salt.
| fmc_src: FMCSEL, | ||
| }; | ||
|
|
||
| pub const D2_Kernel_Config = struct { |
There was a problem hiding this comment.
Suggestion: Rename D2_Kernel_Config to D2_KernelConfig, it should be more in line with our style guidelines. This automation is not perfect so take it with a grain of salt.
| cec_src: CECSEL, | ||
| }; | ||
|
|
||
| pub const D3_Kernel_Config = struct { |
There was a problem hiding this comment.
Suggestion: Rename D3_Kernel_Config to D3_KernelConfig, it should be more in line with our style guidelines. This automation is not perfect so take it with a grain of salt.
github-actions
bot
dismissed
their stale review
Updating with new lint results
| return @intFromFloat(rcc.current_clocks.CortexSysOutput); | ||
| } | ||
|
|
||
| pub var Reset_Reason: rcc.ResetReason = .unknown; |
There was a problem hiding this comment.
Suggestion: Rename Reset_Reason to ResetReason, it should be more in line with our style guidelines. This automation is not perfect so take it with a grain of salt.
1 participant
Uh oh!
There was an error while loading. Please reload this page.