Plonk: Add solidity verifier#1249
Open
georgwiese wants to merge 25 commits intoZokrates:add-bellman-plonk-backendfrom
Open
Plonk: Add solidity verifier#1249georgwiese wants to merge 25 commits intoZokrates:add-bellman-plonk-backendfrom
georgwiese wants to merge 25 commits intoZokrates:add-bellman-plonk-backendfrom
Conversation
georgwiese
commented
Nov 30, 2022
Schaeff
reviewed
Dec 19, 2022
zokrates_proof_systems/src/solidity_renderers/plonk_solidity_renderer.rs
Outdated
Show resolved
Hide resolved
zokrates_proof_systems/src/solidity_renderers/plonk_solidity_renderer.rs
Outdated
Show resolved
Hide resolved
Author
|
Thanks for the review! The integration test fails now, as it did before this PR. I'll try to fix tests in the next PR, which is about splitting the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main changes are:
zokrates_bellman:plonk.rs:serialize_vk()now pre-computesomega. This is redundant, but needed to render the solidity verifier.zokrates_cli:tests/integration.rs: Adjusted thetest_compile_and_witness_dirtest to run only for plonk. It should pass now, testing the full pipeline, including proof verification in solidity.zokrates_proof_systems:solidity_renderer.rs, which is an adjusted version from this code from matter-labs.georgwiese:plonk-add-verifier.PlonkVerifier.sol: The Plonk solidity template, copied and adjusted from this code from matter-labs.scheme/plonk.rs: This file moved to thezokrates_bellmancreate, as mentioned above.to_token.rs: Some refactoringsTo test, run: