Skip to content

Generate crossing ways from crossing nodes when the way only needs to…#74

Draft
dabreegster wants to merge 2 commits intomainfrom
half_crossings
Draft

Generate crossing ways from crossing nodes when the way only needs to…#74
dabreegster wants to merge 2 commits intomainfrom
half_crossings

Conversation

@dabreegster
Copy link
Collaborator

… exist on one side

Closes #69
Screenshot 2026-01-22 at 14 08 11

I need to do some testing more widely, but I think this ought to do the trick

@dabreegster
Copy link
Collaborator Author

Screenshot 2026-01-23 at 10 38 42 Unfortunately, this heuristic creates lots of extra gunk, in cases where a crossing node already has a way, but that way isn't tagged as a crossing -- such as https://www.openstreetmap.org/way/1293977075#map=19/52.751994/13.238300.

There's already a "Missing footway=crossing" problem that detects this problem (though I may remove a restriction that was filtering this only for severances):
Screenshot 2026-01-23 at 10 44 30
Screenshot 2026-01-23 at 10 44 56

Maybe these are all cases where the existing footway attached to the crossing node is an endpoint only, not in the middle. I'll try that.

dabreegster added a commit that referenced this pull request Jan 23, 2026
… node in the middle, not just over severances. Also report all crossing nodes as details, not just the first. See #74 for some examples
@tordans
Copy link
Contributor

tordans commented Jan 23, 2026

Maybe these are all cases where the existing footway attached to the crossing node is an endpoint only, not in the middle.

Agreed

There's already a "Missing footway=crossing" problem that detects this problem (though I may remove a restriction that was filtering this only for severances):

FYI I looked into migrating the code that Rapid has to sync crossing line and nodes data to iD. Still have do document my findings but this looks promising for either iD or Speedwalk. It will require some thinking about the tagging, though. Rapid did a good start but still, one needs to understand and "own" the transformation.

@dabreegster
Copy link
Collaborator Author

Still having trouble getting this to work...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Network: Connect Footway<>Centerline to Generated Sidewalk

2 participants