Enhancement: console.warn when no label is provided #12#122
Open
tgfbikes wants to merge 4 commits intoaaronshaf:masterfrom
Open
Enhancement: console.warn when no label is provided #12#122tgfbikes wants to merge 4 commits intoaaronshaf:masterfrom
tgfbikes wants to merge 4 commits intoaaronshaf:masterfrom
Conversation
added 4 commits
February 2, 2018 22:00
…iaLabelOrAraiLabelledbyAttr utils
…LabelledbyAttr utils
…bel util in componentDidMount passing both refs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an enhancement (idea from @aaronshaf) that will give a warning in the console if the developer does not provide standard label implementation, such as wrapping react-toggle component in a label, providing a label with a 'for' attribute that matches an id prop for a react-toggle component, etc.
Changes to the react-toggle component:
Added second ref to the root div (line 143).
Added componentDidMount life cycle method (line 30).
Added utils:
checkForLabel
hasParentLabel
hasIdThatMatchesLabelFor
hasArialLabelOrAriaLabelledbyAttr