⚡ Bolt: Optimize push_rules hot path (hoist invariants + inline regex)

[abhimehro]

⚡ Bolt Optimization: push_rules Hot Path

💡 What:

• Hoisted sanitize_for_log and string conversions (str(do), etc.) out of the batch processing loop.
• Inlined RULE_PATTERN.match into the rule filtering loop, replacing the is_valid_rule wrapper call.

🎯 Why:

• push_rules processes up to 100k rules per folder.
• sanitize_for_log involves regex substitutions and was called for every batch (e.g. 100 times).
• is_valid_rule adds a Python stack frame for every single rule check (50k+ times).
• These micro-optimizations reduce CPU overhead in the Python loop, allowing the script to spend more time waiting on I/O (which is parallelized).

📊 Impact:

• Validation Loop: ~20% faster (18.8s -> 15.6s for 10k iterations of 4k items).
• Sanitization: ~2.4x faster for batch logging (0.23s -> 0.09s).
• Overall: Reduced CPU usage for large blocklist processing.

🔬 Measurement:

• Benchmarked using timeit on the validation loop and sanitization function.
• Verified functionality with tests/test_push_rules_perf.py and full test suite.

---

PR created automatically by Jules for task 8215016517045155548 started by @abhimehro

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[trunk-io]

😎 Merged manually by @abhimehro - details.

[github-actions]

👋 Development Partner is reviewing this PR. Will provide feedback shortly.

[gemini-code-assist]

Summary of Changes

Hello @abhimehro, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces targeted performance optimizations to the push_rules function, a critical hot path in the Bolt system. By strategically moving invariant computations and inlining frequently called methods, the changes aim to reduce CPU overhead and improve the efficiency of processing large volumes of rules, ultimately allowing the system to spend more time on parallelized I/O operations.

Highlights

• Performance Optimization: Hoisted invariant computations, such as string conversions and sanitize_for_log calls, out of the push_rules batch processing loop to significantly reduce redundant calculations.
• Micro-optimization: Inlined the RULE_PATTERN.match method directly into the rule filtering loop, replacing the is_valid_rule wrapper, to minimize Python stack frame overhead for each rule check.
• Measured Impact: Achieved approximately a 20% speedup in the validation loop and a 2.4x faster batch logging sanitization, leading to reduced CPU usage for processing large blocklist rule sets.

Changelog

• .jules/bolt.md
  • Added a new learning entry detailing the benefits and actions for hoisting invariants and inlining methods in performance-critical loops.
• main.py
  • Replaced direct calls to is_valid_rule with a local reference to RULE_PATTERN.match within the rule validation loop for improved performance.
  • Hoisted str() conversions for do, status, and folder_id, along with sanitize_for_log(folder_name) and progress_label string formatting, outside the process_batch function to prevent redundant computations.
  • Updated logging and progress bar rendering calls to utilize the newly hoisted and pre-computed variables.
• tests/test_push_rules_perf.py
  • Modified the test_push_rules_skips_validation_for_existing test to mock main.RULE_PATTERN and its match method, aligning with the updated validation logic in main.py.
  • Adjusted the assertion in the test to verify mock_match was called correctly instead of mock_is_valid.

Activity

• PR created automatically by Jules for task 8215016517045155548, initiated by @abhimehro.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request successfully optimizes the push_rules function by hoisting invariant computations and inlining regex matching. These changes significantly reduce CPU overhead in the hot path when processing large rule sets (up to 100k rules). The tests have been correctly updated to reflect the inlining of the regex pattern. I have suggested a small further improvement to hoist the folder name sanitization even earlier to cover the validation loop's warning messages, ensuring maximum efficiency in the hot path.

[gemini-code-assist]

To fully leverage the hoisting optimization, sanitize_for_log(folder_name) should be moved before the validation loop. This avoids redundant calls to the sanitization function (which performs regex substitutions) for every unsafe rule encountered in the hot path.

    match_rule = RULE_PATTERN.match
    sanitized_folder_name = sanitize_for_log(folder_name)

    for h in unique_hostnames:
        if h in existing_rules:
            continue

        if not match_rule(h):
            log.warning(
                f"Skipping unsafe rule in {sanitized_folder_name}: {sanitize_for_log(h)}"

[Copilot]

Pull request overview

This PR optimizes the push_rules function's hot path, which processes up to 100k rules per folder. The optimization includes hoisting loop invariants (string conversions and sanitization calls) and inlining the regex pattern match to eliminate function call overhead.

Changes:

• Inlined RULE_PATTERN.match directly in the validation loop to avoid is_valid_rule function call overhead (~20% faster validation)
• Hoisted invariant computations (string conversions, sanitization) out of the batch processing loop (~2.4x faster sanitization)
• Updated test to mock RULE_PATTERN instead of is_valid_rule to align with the new implementation

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
main.py	Optimized push_rules hot path by inlining regex match and hoisting invariant computations
tests/test_push_rules_perf.py	Updated test to mock RULE_PATTERN instead of the removed is_valid_rule call
.jules/bolt.md	Documented the optimization learnings for future reference

[github-actions]

👋 Development Partner is reviewing this PR. Will provide feedback shortly.

[github-actions]

👋 Development Partner is reviewing this PR. Will provide feedback shortly.

[github-actions]

👋 Development Partner is reviewing this PR. Will provide feedback shortly.