forked from keksiqc/ctrld-sync
-
Notifications
You must be signed in to change notification settings - Fork 0
🎨 Palette: Enhance CLI Progress Bars and Summary Table #292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
abhimehro
wants to merge
1
commit into
main
Choose a base branch
from
palette-micro-ux-table-progress-14389183363023798547
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+96
−30
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,7 @@ | ||
| ## 2025-01-26 - [Silent Waits in CI] | ||
| **Learning:** Long silent waits in CLI tools (especially in CI/non-interactive mode) cause user anxiety about hung processes. | ||
| **Action:** Always provide periodic heartbeat logs (e.g. every 10s) for long operations in non-interactive environments. | ||
|
|
||
| ## 2025-02-14 - [ASCII Fallback for Tables] | ||
| **Learning:** Using Unicode box drawing characters enhances the CLI experience, but a robust ASCII fallback is crucial for CI environments and piped outputs. | ||
| **Action:** Always implement a fallback mechanism (like checking `sys.stderr.isatty()`) when using rich text or Unicode symbols. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new table rendering functionality (Box class and card-style summary table) lacks test coverage. Given that this project has comprehensive test coverage across 16 test files, the new visual features should have corresponding tests to verify that box-drawing characters are used correctly in interactive mode and fall back to ASCII characters in non-interactive mode. Consider adding tests similar to test_countdown_timer_visuals that verify the Box class characters appear in the table output when USE_COLORS is True and ASCII fallbacks appear when USE_COLORS is False.