[Flags] Use option instead of long cast statements#919
Draft
abhinavsingh wants to merge 2 commits intodevelopfrom
Draft
[Flags] Use option instead of long cast statements#919abhinavsingh wants to merge 2 commits intodevelopfrom
option instead of long cast statements#919abhinavsingh wants to merge 2 commits intodevelopfrom
Conversation
…d delegate resolution to flag initializer. This makes flag class independent of cli arg names
abhinavsingh
added
the
bot:chronographer:skip
Codecov Report
@@ Coverage Diff @@
## develop #919 +/- ##
========================================
Coverage 86.19% 86.19%
========================================
Files 145 145
Lines 6380 6382 +2
Branches 646 646
========================================
+ Hits 5499 5501 +2
Misses 761 761
Partials 120 120
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO:
Also try to automate and delegate resolution to flag initializer. This makes flag class independent of cli arg names.