Enable use of alchemical pseudoatoms #386
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some changes in AbinitInput object to allow for alchemical pseudoatoms: - Remove check on the length of znucl - Accept list of provided pseudos when znucl is specified. Note that the check on the length of znucl is also present in pymatgen.io.abinit.abiobjects which will have to be updated.
Version checking no longer raises an error when the abinit version number is appended with a string like '-XXXX'. Fix the run_relax example: - Needed chksymtnons=0 - Remove an additional bands_work that was not actually performing bandstructure work, and whose dependencies were broken.
Contributor
Author
|
I cannot reproduce the failing tests. They succeed on my machine... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes in AbinitInput object to allow for alchemical pseudoatoms:
Note that the check on the length of znucl is also present in pymatgen.io.abinit.abiobjects which will have to be updated.