Open
Conversation
maliming
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request addresses a security vulnerability by removing the deprecated and vulnerable jquery-form npm package and replacing its functionality with a custom implementation using modern browser APIs. Additionally, it adds a missing peer dependency (moment) to the bootstrap-daterangepicker package.
Changes:
- Removed the vulnerable
@abp/jquery-formpackage dependency from the shared theme package - Replaced jquery-form's
ajaxFormfunctionality with a custom implementation using nativeFormDataAPI and jQuery's$.ajax - Added missing
@abp/momentdependency to@abp/bootstrap-daterangepickerpackage (required by the underlying library) - Removed
JQueryFormScriptContributorclass and its references from the bundling configuration
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| npm/packs/bootstrap-daterangepicker/package.json | Added missing @abp/moment dependency required by bootstrap-daterangepicker library |
| npm/packs/aspnetcore.mvc.ui.theme.shared/package.json | Removed vulnerable @abp/jquery-form dependency from shared theme package |
| framework/src/Volo.Abp.AspNetCore.Mvc.UI.Theme.Shared/wwwroot/libs/abp/aspnetcore-mvc-ui-theme-shared/jquery-form/jquery-form-extensions.js | Replaced jquery-form library usage with custom implementation using FormData API and jQuery.ajax |
| framework/src/Volo.Abp.AspNetCore.Mvc.UI.Theme.Shared/Bundling/SharedThemeGlobalScriptContributor.cs | Removed references to JQueryFormScriptContributor and its using statement |
| framework/src/Volo.Abp.AspNetCore.Mvc.UI.Packages/Volo/Abp/AspNetCore/Mvc/UI/Packages/JQueryForm/JQueryFormScriptContributor.cs | Deleted obsolete JQueryFormScriptContributor class that wrapped the vulnerable package |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #24702