Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
derekmauro
requested changes
Nov 26, 2025
Member
derekmauro
left a comment
There was a problem hiding this comment.
It should be far simpler to achieve this. I believe all that needs to be done is a slight tweak here and everything else should just work:
abseil-cpp/absl/base/internal/low_level_alloc.h
Lines 34 to 41 in 9d35bf5
Signed-off-by: Bailey Hayes <bailey@cosmonic.com>
Author
|
Thank you that simplified it quite a bit 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today, WASI does not support atomics. Support for WASI in Abseil was added in #1509 and needs to be refreshed.
Note that there is a roadmap item for wasi that will give us access to atomics via the component model's cooperative threads feature. Implementations are in progress but this may take a few months and so in the mean time, we need this fix.
I created an example with the necessary stubs that are missing from upstream abseil and validated that these can be removed with the changes in this PR: https://github.com/ricochet/wasi-protobuf/blob/main/wasi-build/wasi_stubs.cpp