Skip to content

Conversation

@felixgateru
Copy link
Contributor

What type of PR is this?

This is a feature because it adds the ability to filter etity listing by period in which they were created

What does this do?

This pr:

  • adds created_from and created_to query parameters to entities listing
  • updates tests for these changes
  • updates docs for these changes

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Yes, tests have been updated

Did you document any new/modified feature?

yes, api docs are updated

Notes

@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

❌ Patch coverage is 98.30508% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.11%. Comparing base (20bafe0) to head (7fbda9f).

Files with missing lines Patch % Lines
groups/api/http/decode.go 86.66% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3339      +/-   ##
==========================================
+ Coverage   74.83%   79.11%   +4.28%     
==========================================
  Files         160      141      -19     
  Lines       18890    18287     -603     
==========================================
+ Hits        14136    14468     +332     
+ Misses       3904     2916     -988     
- Partials      850      903      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@felixgateru felixgateru marked this pull request as ready for review February 3, 2026 16:02
@felixgateru felixgateru requested a review from a team as a code owner February 3, 2026 16:02
dborovcanin
dborovcanin previously approved these changes Feb 4, 2026
@dborovcanin
Copy link
Collaborator

@felixgateru Please rebase.

Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
@dborovcanin
Copy link
Collaborator

@nyagamunene Please review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Add filtering entities based on a period e.g., entities created between period1 and period2

2 participants