Medical - Add API to directly add wounds to units#11211
Medical - Add API to directly add wounds to units#11211Cplhardcore wants to merge 6 commits intoacemod:masterfrom
Conversation
|
Pretty sure API go in |
Cplhardcore
changed the title
Co-authored-by: Dart <59131299+DartRuffian@users.noreply.github.com>
Co-authored-by: Dart <59131299+DartRuffian@users.noreply.github.com>
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
| * 2.0: Wound Type <STRING> | ||
| * 2.1: Amount <NUMBER> | ||
| * 2.2: Size (0 - 2) <NUMBER> | ||
| * 2.3: Wound Damage <NUMBER> |
There was a problem hiding this comment.
This some new styling choice? I haven't seen any other ace function do this. They're always:
/*
* 0: Whatever <ARRAY>
* 0: Foo <...>
* 1: Bar <...>There was a problem hiding this comment.
its a subset of a param, so it made sense to make it still contain the number of the param
There was a problem hiding this comment.
Dart's example is what's usually used in ACE, please follow it.
| _createdWounds = true; | ||
| _bodyPartVisParams set [[1,2,3,3,4,4] select _bodyPartNToAdd, true]; | ||
| if (_createdWounds) then { | ||
| _unit setVariable [VAR_OPEN_WOUNDS, _openWounds, true]; |
There was a problem hiding this comment.
Don't we always want to sync this, even if just merging into an existing wound?
If we don't sync then the bleeding local players sees is different from what remote players see for them?
I know this is based on https://github.com/acemod/ACE3/blob/master/addons/medical_damage/functions/fnc_woundsHandlerBase.sqf#L199 so I'm worried it effects that as well
There was a problem hiding this comment.
If its being merged with an old one, there will already be bloody clothing, so there's no need to update it
There was a problem hiding this comment.
It should probably still be updated to avoid cases where remote players see different bleeding than the local player. The network cost to avoid it is negligible IMO.
6 participants
When merged this pull request will:
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.