Support for async non blocking predict method in Prediction IO and async non blocking ES access#62
Open
longliveenduro wants to merge 4 commits intoactionml:developfrom
Open
Support for async non blocking predict method in Prediction IO and async non blocking ES access#62longliveenduro wants to merge 4 commits intoactionml:developfrom
longliveenduro wants to merge 4 commits intoactionml:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to leverage the already present async interface of elasticsearch and armouring the not so crucial parts (like getting the app) with blocking constructs which will tell the standard scala ExecutionContext to use a separate thread for that.
Let me know what you think,
See also apache/predictionio#495