Open
Conversation
Enable pushing for testing
ethack
commented
Jun 8, 2021
Contributor
Author
ethack
left a comment
ethack
left a comment
There was a problem hiding this comment.
These are the changes needed before merging after it's been tested.
|
|
||
| on: | ||
| push: | ||
| branches: [ main, github-workflow-build ] |
Contributor
Author
There was a problem hiding this comment.
Remove github-workflow-build
| with: | ||
| platforms: linux/amd64,linux/arm64,linux/arm/v7 | ||
| tags: | | ||
| activecm/passer:test |
Contributor
Author
There was a problem hiding this comment.
Change test to latest
| name: Build and push | ||
| uses: docker/build-push-action@v2 | ||
| with: | ||
| platforms: linux/amd64,linux/arm64,linux/arm/v7 |
Contributor
Author
There was a problem hiding this comment.
Remove any platforms that aren't working
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First pass at a github action replacement for docker build.
Also tests building for arm7 and arm64.