actix-http: play with allowing bytes passthrough in the h1 encoder#3368
Open
asonix wants to merge 15 commits intoactix:mainfrom
Open
actix-http: play with allowing bytes passthrough in the h1 encoder#3368asonix wants to merge 15 commits intoactix:mainfrom
asonix wants to merge 15 commits intoactix:mainfrom
Conversation
Contributor
Author
|
I added a couple additional endpoints to the actix-web example in actix-http so I could run CPU: command: for note that this isn't testing streaming bodies |
Open
4 tasks
Contributor
Author
|
probably semver-major now :) but this is mostly for comment on direction rather than an immediate request to merge |
Contributor
Author
|
related: BigBytes seems like a terrible name and I would love a better one :p |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
?????Bug?????? (reduces memory use)
PR Checklist
Overview
This is just me playing around with how to possibly avoid growing a persistent buffer to incredibly large sizes by allowing already-allocated Bytes types to pass through directly to IO in the h1 dispatcher
Comments very welcome
relates to #3367