feat(awc): allow to set a specific sni host on the request#3522
Open
joelwurtz wants to merge 2 commits intoactix:mainfrom
Open
feat(awc): allow to set a specific sni host on the request#3522joelwurtz wants to merge 2 commits intoactix:mainfrom
joelwurtz wants to merge 2 commits intoactix:mainfrom
Conversation
joelwurtz
commented
Dec 9, 2024
| let authority = if let Some(authority) = head.uri.authority() { | ||
| authority | ||
| } else { | ||
| return ConnectRequestFuture::Error { |
Contributor
Author
There was a problem hiding this comment.
there may be a better way, but a lot of code need to be updated and was not sure about the correct / standard thing to do here, this is a pragmatic way of doing it, but if you have an idea on how to avoid this will be glad to hear.
joelwurtz
commented
Dec 9, 2024
ffef23c to
1647a03
Compare
5 tasks
50f296f to
d151822
Compare
d151822 to
0915879
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Feature
PR Checklist
Overview
This PR allow client to set a specific sni host for a request, this can be useful if you want to connect to a specific hostname, but do SSL validation on another one
In order to do that some thing have been changed :
There may be better implementation on some point, as i have done what it's the most pragmatic way as a first step, will be happy to fix those if you have some inputs.