Add support for project specific environment variables#263
Open
gregd72002 wants to merge 9 commits intoadashen:developfrom
Open
Add support for project specific environment variables#263gregd72002 wants to merge 9 commits intoadashen:developfrom
gregd72002 wants to merge 9 commits intoadashen:developfrom
Conversation
gregd72002
changed the title
|
I'm currently using this fork rather than the original one because I need the environment variables to be able to even launch my war package. Thanks for the work, it works flawlessly ! |
andxu
reviewed
Jun 29, 2020
src/Utility.ts
Outdated
|
|
||
| export function setEnv(workdir: string): void { | ||
| projectEnv = {}; | ||
| let fpath = workdir+'/.env'; |
Collaborator
There was a problem hiding this comment.
path.join(workdir, '.env');
Collaborator
|
Please also resolve the conflicting files. |
- Removed deprecated vscode.workspace.rootPath-
|
Hi all, I have created a PR to @gregd72002's repository making required changes to merge it here. Waiting for a response. |
Prepare brach to merge into adashen's
Author
|
@roberfi thanks. This is now merged into my repository. |
Eskibear
reviewed
Oct 15, 2021
| const httpsPort: string = await Utility.getPort(serverConfig, Constants.PortKind.Https); | ||
|
|
||
| if (vscode.workspace.workspaceFolders.length > 0) { | ||
| Utility.setEnv(vscode.workspace.workspaceFolders[0].uri.path); |
Collaborator
There was a problem hiding this comment.
hardcode workspaceFolder[0] doesn't seem to be good. What if I have multiple workspace folders, and the app to launch is not under the first one?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses: #248
Create .env file in your project folder.
See https://www.npmjs.com/package/dotenv for details.