Suggestion: set default of maxP to NULL#14
Open
mja wants to merge 1 commit intoadhikari-statgen-lab:mainfrom
Open
Suggestion: set default of maxP to NULL#14mja wants to merge 1 commit intoadhikari-statgen-lab:mainfrom
mja wants to merge 1 commit intoadhikari-statgen-lab:mainfrom
Conversation
Author
|
Maybe also this parameter could have a different name since the value it accepts is interpreted as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current biobank and meta-GWAS are well-powered enough that almost all will contain a P-value smaller than 1e-14, so there isn't a single value that is sensible default for truncating the Y axis. This PR sets
maxP=NULLas the default.