Skip to content

Issue #2989 [DefaultPathProcessor] Implementation-dependent tests in testVanityUrl and testVanityConfig #2991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kabo87777 wants to merge 3 commits into
base: main
Choose a base branch
from
+39 −8
Open

Issue #2989 [DefaultPathProcessor] Implementation-dependent tests in testVanityUrl and testVanityConfig #2991

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3354c26
fix ID test in DefaultPathProcessorTest
kabo87777 Sep 30, 2025
860e414
fix testVanityConfig ID test
kabo87777 Oct 1, 2025
36041d3
remove the unnecessary end-of-line change at the end of the file
kabo87777 Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 39 additions & 8 deletions ...rc/test/java/com/adobe/cq/wcm/core/components/internal/link/DefaultPathProcessorTest.java
View file
Open in desktop
Copy link

@santhanbattina santhanbattina Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement here, I like the direction of making these tests less dependent on implementation details.

One small thought: vanity URL tests can get flaky if they rely on implicit ordering or default configs from the test environment. Maybe we can make the setup a bit more explicit so the expected result is fully deterministic (especially if multiple vanity values exist).

Not a blocker at all, just something that might help avoid future CI surprises. Overall this looks good to me.

Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,15 @@ void testSanitizeExternalLink() {
void testVanityUrl() {
Page page = context.create().page("/content/links/site1/en", "/conf/example",
ImmutableMap.of("sling:vanityPath", "vanity.html"));

Externalizer externalizer = context.getService(Externalizer.class);
if (externalizer == null) {
externalizer = mock(Externalizer.class);
when(externalizer.publishLink(any(ResourceResolver.class), anyString()))
.thenAnswer(invocation -> "https://example.org" + invocation.getArgument(1, String.class));
context.registerService(Externalizer.class, externalizer);
}

DefaultPathProcessor underTest = context.registerInjectActivateService(new DefaultPathProcessor(), ImmutableMap.of(
"vanityConfig", DefaultPathProcessor.VanityConfig.MAPPING.getValue()));
assertTrue(underTest.accepts(page.getPath() + HTML_EXTENSION, context.request()));
Expand All @@ -114,13 +123,35 @@ void testVanityUrl() {
void testVanityConfig() {
Page page = context.create().page("/content/links/site1/en", "/conf/example",
ImmutableMap.of("sling:vanityPath", "vanity.html"));
DefaultPathProcessor underTest = context.registerInjectActivateService(new DefaultPathProcessor(), ImmutableMap.of(
"vanityConfig", "shouldBeDefault"));
assertEquals("/content/site1/en.html", underTest.map(page.getPath() + HTML_EXTENSION, context.request()));
assertEquals("https://example.org/content/site1/en.html", underTest.externalize(page.getPath() + HTML_EXTENSION, context.request()));
context.request().setContextPath("/cp");
underTest = context.registerInjectActivateService(new DefaultPathProcessor(), ImmutableMap.of(
"vanityConfig", DefaultPathProcessor.VanityConfig.ALWAYS.getValue()));
assertEquals("/cp/vanity.html", underTest.sanitize(page.getPath() + HTML_EXTENSION, context.request()));

Externalizer externalizer = context.getService(Externalizer.class);
if (externalizer == null) {
externalizer = mock(Externalizer.class);
when(externalizer.publishLink(any(ResourceResolver.class), anyString()))
.thenAnswer(invocation -> "https://example.org" + invocation.getArgument(1, String.class));
context.registerService(Externalizer.class, externalizer);
}

String htmlPath = page.getPath() + HTML_EXTENSION;

ResourceResolver rrKeep = mock(ResourceResolver.class);
when(rrKeep.map(any(SlingHttpServletRequest.class), anyString()))
.thenAnswer(inv -> inv.getArgument(1));
when(rrKeep.map(anyString()))
.thenAnswer(inv -> inv.getArgument(0));
MockSlingHttpServletRequest reqKeep = new MockSlingHttpServletRequest(rrKeep);
DefaultPathProcessor underTest = context.registerInjectActivateService(new DefaultPathProcessor(), ImmutableMap.of("vanityConfig", "shouldBeDefault"));
assertEquals(htmlPath, underTest.map(htmlPath, reqKeep));
assertEquals("https://example.org" + htmlPath, underTest.externalize(htmlPath, reqKeep));

ResourceResolver rrVanity = mock(ResourceResolver.class);
when(rrVanity.map(any(SlingHttpServletRequest.class), anyString()))
.thenReturn("/vanity.html");
when(rrVanity.map(anyString()))
.thenReturn("/vanity.html");
MockSlingHttpServletRequest reqVanity = new MockSlingHttpServletRequest(rrVanity);
reqVanity.setContextPath("/cp");
underTest = context.registerInjectActivateService(new DefaultPathProcessor(), ImmutableMap.of("vanityConfig", DefaultPathProcessor.VanityConfig.ALWAYS.getValue()));
assertEquals("/cp/content/links/site1/en.html", underTest.sanitize(htmlPath, reqVanity));
}
}