This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Fix for parameter hints not showing when using tabs instead of spaces#15018
Open
SietseB wants to merge 2 commits intoadobe:masterfrom
Open
Fix for parameter hints not showing when using tabs instead of spaces#15018SietseB wants to merge 2 commits intoadobe:masterfrom
SietseB wants to merge 2 commits intoadobe:masterfrom
Conversation
Parameter hints were not showing when using the tab character for indents. In case of spaces a column number equals the character position in the line string, but in case of tabs that trick doesn't work. This fix converts a column number to a character position, taking tabs into account.
swmitra
approved these changes
Feb 11, 2020
Collaborator
swmitra
left a comment
swmitra
left a comment
There was a problem hiding this comment.
Interesting solution to handle tabs 👍
Change looks good to me, please test JS intellisense features once before merging.
Using the build-in method Editor.getCharIndexForColumn results in much shorter and cleaner code.
|
@SietseB i've squashed and merged your changes into https://github.com/brackets-cont/brackets |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parameter hints are not showing when using the tab character for indents.
In case of spaces a column number equals the character position in the line string, but in case of tabs that trick doesn't work.
This fix converts a column number to a character position, taking tabs into account.