Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

Fix for method "getUserByUids" with mongodb database#40

Open
ghost wants to merge 8 commits intomasterfrom
develop
Open

Fix for method "getUserByUids" with mongodb database#40
ghost wants to merge 8 commits intomasterfrom
develop

Conversation

@ghost
Copy link

@ghost ghost commented Sep 18, 2020

Hi,
i'm using mongodb as Database, with lucid-mongo.

Unfortunately when Person uses the internal method getUserByUids() (in the methods verify() and forgotPassword()) fails because tries to search users using the method userQuery.orWhere() that doesn't exist in mongo.

To fix this would be nice to check if this method exists and fallback to the method findBy() of mongo.

Persona js 2020-09-18 15-13-59

Thank you for your great work.

Best regards,
Florian

rhwilr and others added 8 commits June 23, 2018 00:06
@coveralls
Copy link

coveralls commented Sep 18, 2020

Pull Request Test Coverage Report for Build 48

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.514%

Totals Coverage Status
Change from base Build 24: 0.0%
Covered Lines: 136
Relevant Lines: 141

💛 - Coveralls

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants