Adding logic to download liberty client stuffs

[dennycjacob]

Related Issue:https://github.ibm.com/runtimes/automation/issues/800

[smlambert]

hi @dennycjacob - I know this is still in draft but wanted to intervene before you get to far into the changes:

• every PR in this repo should be associated with an open issue describing the problem you are trying to fix
• we would not fetch the liberty materials via the get.sh file, we would manage liberty dependencies like how we manage other dependencies, via getDependencies.pl logic, or via build.xml (ant scripts) depending on the test category, if you are looking at modifying the Liberty perf setup, it looks like its currently done via a call to config_liberty.sh, and where we'd expect the download URL to be publicly accessible

If you indicate what you hope to achieve, we can probably advise on preferred methods of doing it.

[dennycjacob]

@smlambert - The goal is to move the whole Liberty Binaries and Client related materials to artifactory , so that we can download them to the liberty_root folder in the host machine during run time of performance benchmark runs and later delete them , after each run.
https://github.ibm.com/runtimes/rt-performance/blob/main/perf/libertydaytrader/run_liberty_throughput_jenkins.sh#L40-L46
Right now, we are copying these materials manually to each machines after the machine setup, which is not ideal.
I think we can move this logic to https://github.ibm.com/runtimes/rt-performance/blob/main/perf/libertydaytrader/run_liberty_throughput_jenkins.sh , so that we dont have to modify the get.sh file.
@sobirada - Do u have anything to add?

[smlambert]

I think we can move this logic to https://github.ibm.com/runtimes/rt-performance/blob/main/perf/libertydaytrader/run_liberty_throughput_jenkins.sh , so that we dont have to modify the get.sh file.

Thanks yes, it is preferred not to modify the get.sh file, and keeps to our preference for managing the download of dependencies used only by a particular test within the scope of that test. You could also edit that test's build.xml file (ant script) to pick up and unpack certain dependencies. An example of this can be seen here and here.