Add layout direction support to library#50
Open
nasrabadiAM wants to merge 7 commits intoadrielcafe:mainfrom
Open
Add layout direction support to library#50nasrabadiAM wants to merge 7 commits intoadrielcafe:mainfrom
nasrabadiAM wants to merge 7 commits intoadrielcafe:mainfrom
Conversation
Collaborator
|
In the first glance, I think layout direction could be easily implemented as a extension function instead of a actual configuration that the Strings data class have. val locale = Locale.forLanguageTag(localeStr)
val layoutDirection = TextUtils.getLayoutDirectionFromLocale(locale)I don't see a UseCase where a simple extension that gets the current Lyricist locale and apply the LayoutDirection using platform Locale apis. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Layout Direction Support to Lyricist
Description:
This pull request introduces support for layout direction alongside resources in the
lyricistlibrary. This feature is essential for applications that need to support right-to-left (RTL) languages such as Arabic, Hebrew, and Persian. By integrating layout direction handling, developers can ensure that their applications provide a seamless and user-friendly experience for RTL language users.Changes Introduced:
lyricist.Use Case:
Consider an application that supports both English (LTR) and Arabic (RTL) languages. With this feature, developers can easily configure resources and layout direction preferences for each language, ensuring a polished and accessible experience for users regardless of their language's text direction.
Additional Notes:
This pull request addresses the feature request I submitted in issue #47. Initially, I implemented this feature for my own usage due to the lack of response on the issue. If this aligns with the goals of the
lyricistproject, I would be thrilled to see it merged into the main codebase. If not, please feel free to close this pull request.Thank you for your consideration. I look forward to any feedback or suggestions you may have.
Contact Information:
Please feel free to reach out if further clarification or details are needed regarding this implementation.