Internal exception message exposure for login action in Sylius
Package
Affected versions
< 1.3.14
>= 1.4.0, < 1.4.10
>= 1.5.0, < 1.5.7
>= 1.6.0, < 1.6.3
Patched versions
1.3.14
1.4.10
1.5.7
1.6.3
Description
Published to the GitHub Advisory Database
Dec 5, 2019
Reviewed
Jun 16, 2020
Last updated
Jan 9, 2023
Internal exception message exposure for login action
Impact
Exception messages from internal exceptions (like database exception) are wrapped by
\Symfony\Component\Security\Core\Exception\AuthenticationServiceExceptionand propagated through the system to UI. Therefore, some internal system information may leak and be visible to the customer.A validation message with the exception details will be presented to the user when one will try to log into the shop.
Patches
Has the problem been patched? What versions should users upgrade to?
Workarounds
The
src/Sylius/Bundle/UiBundle/Resources/views/Security/_login.html.twigfile should be overridden and lines https://github.com/Sylius/Sylius/blob/1.4/src/Sylius/Bundle/UiBundle/Resources/views/Security/_login.html.twig#L13-L17 should be replaced with{% if last_error %} <div class="ui left aligned basic segment"> {{ messages.error(last_error.messageKey) }} </div> {% endif %}The
messageKeyfield should be used instead of themessage.References