CLIENT-3751: Added Path Expressions support#920
Open
DomPeliniAerospike wants to merge 2 commits intodevfrom
Open
CLIENT-3751: Added Path Expressions support#920DomPeliniAerospike wants to merge 2 commits intodevfrom
DomPeliniAerospike wants to merge 2 commits intodevfrom
Conversation
DomPeliniAerospike
changed the title
Collaborator
juliannguyen4
left a comment
juliannguyen4
left a comment
There was a problem hiding this comment.
Hi Dominic, I reviewed the whole PR and left some suggestions. If you could address them that'd be great.
typings/index.d.ts
Outdated
| * | ||
| * @param bin - bin name. | ||
| * @param valueType - expression value type. | ||
| * @param flags - path selct flags. |
typings/index.d.ts
Outdated
| * @param bin - bin name. | ||
| * @param valueType - expression value type. | ||
| * @param modExp - expression for modificaiton. | ||
| * @param flags - path selct flags. |
typings/index.d.ts
Outdated
| * | ||
| * @param bin - bin name. | ||
| * @param context - CDT Context. | ||
| * @param flags - path selct flags. |
| 'src/main/map_operations.cc', | ||
| 'src/main/bit_operations.cc', | ||
| 'src/main/hll_operations.cc', | ||
| 'src/main/cdt_operations.cc', |
Collaborator
There was a problem hiding this comment.
Long term suggestion (unrelated): may be better to recursively get all the source code files. In the Python client I use this line instead so I don't have to update my compile script setup.py:
source_files = glob.glob(pathname="src/main/**/*.c", recursive=True)
out.txt
Outdated
| @@ -0,0 +1,2 @@ | |||
| link eth0 state up | |||
Collaborator
There was a problem hiding this comment.
Assuming this was used for debugging. Should be removed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
exp.selectByPath
operations.selectByPath
exp.modifyByPath
operations.modifyByPath
loop variables
loopVarPart
pathSelectFlags
pathModifyFlags