feat(meta-touch-controls): add support for Meta Quest 3S Xbox Edition#5753
feat(meta-touch-controls): add support for Meta Quest 3S Xbox Edition#5753mimosapudical wants to merge 2 commits intoaframevr:masterfrom
Conversation
| 'meta-quest-touch-plus-v2': { | ||
| left: { | ||
| modelUrl: META_CONTROLLER_MODEL_BASE_URL + 'quest-touch-plus-v2-left.glb', | ||
| rayOrigin: { origin: {x: 0.0065, y: -0.0186, z: -0.05}, direction: {x: 0.1239, y: -0.5944, z: -0.7945} }, |
There was a problem hiding this comment.
Is there any reason the values for direction are truncated? I would expect it to be identical to the meta-quest-touch-plus bar the modelUrl.
|
Thanks for the PR. Do you happen to have the Meta Quest 3S Xbox Edition controllers? The profiles list for these should report The models can be found in the |
Updated meta-quest-touch-plus-v2 to keep the same rayOrigin values as meta-quest-touch-plus (full precision kept, only modelUrl differs).
Thanks for the feedback! I don’t have the Meta Quest 3S Xbox Edition controllers, so I couldn’t test with the actual hardware. I have added explicit support for the meta-quest-touch-plus-v2 profile in the component without including the model files. The controller should still fall back to meta-quest-touch-plus and work in A-Frame. I have also created a separate PR on aframevr/assets to add the corresponding models from the webxr-input-profiles repository. |
Description:
Changes proposed:
-This PR adds support for the meta-quest-touch-plus-v2 profile in the meta-touch-controls component.
-Currently, the Xbox Edition model files are not included, so the component will fall back to using the existing meta-quest-touch-plus models.
-The profile recognition logic is implemented and ready for use.