Conversation
Atdgen needs more work.
5 tasks
1 task
Collaborator
Author
|
This attempt to support dedicated syntax for imports failed due to the complexity of the atdgen implementation. The problem is that atdgen generates code that doesn't read or write via a generic JSON AST but instead reads and writes JSON directly to/from bytes. This makes things unmanageable. I didn't have any problems supporting Here's what I suggest:
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This provides an
importconstruct that serves as declaring the existence of a module. A modulemis derived from an ATD filem.atdor some implementation that exposes a compatible interface. A typetprovided by modulemis referred to asm.t.Implements #265
PR checklist
CHANGES.mdis up-to-date