Add automated ATD rule generation guide for Dune#434
Open
octoio wants to merge 3 commits intoahrefs:masterfrom
Open
Add automated ATD rule generation guide for Dune#434octoio wants to merge 3 commits intoahrefs:masterfrom
octoio wants to merge 3 commits intoahrefs:masterfrom
Conversation
octoio
requested review from
Khady,
cyberhuman,
mjambon,
rgrinberg and
zindel
as code owners
Contributor
|
generally looking good, thanks. We have something similar internally, really useful. Could potentially be good to ship such an executable directly. I wonder if the mode fallback is good or not. Might be a trap for people who are not very careful. But no strong opinion yet. |
Author
I can definitely update to remove the fallback mode. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
[ ] New code has tests to catch future regressions[ ]CHANGES.mdis up-to-dateI've been using the atd project a lot in my ocaml projects. I was tired of manually updating my
dunefiles manually and decided to take a stab at generating the dune rule for all my atd files. You can see how I personally use the generation in my project.Hopefully this can help people 😃