refactor: simplify code and reduce duplication#110
Merged
Wh1isper merged 2 commits intoai-zerolab:mainfrom Feb 14, 2026
Merged
Conversation
- Fix typo: DEFAILT_CONFIG_PATH -> DEFAULT_CONFIG_PATH - Consolidate duplicate _parse_bool_env functions into one - Remove unnecessary `return` statement in store_settings - Have EmailBodyResponse extend EmailMetadata to avoid field duplication - Add in_reply_to and references params to abstract send_email interface - Extract _parse_recipients and _parse_date helper methods in EmailClient - Add MAX_BODY_LENGTH constant instead of magic number - Add missing return type annotation to _build_search_criteria Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
jbkjr
pushed a commit
to jbkjr/mcp-email-server
that referenced
this pull request
Jan 25, 2026
Apply improvements from upstream PR ai-zerolab#110: - Fix typo: DEFAILT_CONFIG_PATH -> DEFAULT_CONFIG_PATH - Consolidate duplicate _parse_bool_env functions into one - Remove unnecessary `return` statement in store_settings - Have EmailBodyResponse extend EmailMetadata to avoid field duplication - Add in_reply_to and references params to abstract send_email interface - Extract _parse_recipients and _parse_date helper methods in EmailClient - Add MAX_BODY_LENGTH constant instead of magic number - Add missing return type annotation to _build_search_criteria Additional improvements for local-dev extra features: - Add LABELS_PREFIX constant for ProtonMail label paths - Remove redundant `import re` inside search_by_message_id method Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DEFAILT_CONFIG_PATH->DEFAULT_CONFIG_PATH_parse_bool_envfunctions into one module-level functionreturnstatement instore_settingsEmailBodyResponseextendEmailMetadatato avoid field duplicationin_reply_toandreferencesparams to abstractsend_emailinterface to match implementation_parse_recipientsand_parse_datehelper methods inEmailClientto reduce code duplicationMAX_BODY_LENGTHconstant instead of magic number20000_build_search_criteriaTest plan
🤖 Generated with Claude Code