-
-
Notifications
You must be signed in to change notification settings - Fork 117
New MultiDict C-API functions And Added Documentation #1185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 28 commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
09b466b
make capsule api functions less generic by adding a namespace to prev…
Vizonex 0b08ba3
missed a function let me fix it real fast...
Vizonex baf4e6a
lets add some documentation comments to these functions
Vizonex 8356ff2
time to add a few more functions, I'm adding more shortly...
Vizonex c884dcb
Fill out more functions and concept ideas
Vizonex dc2bcc7
all the Multidict Object API Next will be istr...
Vizonex 904fb82
reformat with clang-format
Vizonex 0ebbdf1
add more functions to testcapi :)
Vizonex ecd898c
add contribution to changes folder
Vizonex efa70f5
Revert namespace idea unsure if it actually will cause compiling issues
Vizonex 9036575
Revert namespace idea unsure if it actually will cause compiling issues
Vizonex 17b560d
I kept my good old backups
Vizonex 4e08873
fix compiling with previously proposed api
Vizonex c04d584
discovered that md_new(...) is causing segfaults, gonna need to inves…
Vizonex 6c80da6
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 721b593
Adding a reference count by 1 solves the segfault
Vizonex 670fe1d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 233545f
Now that we know a bit more about refs let's change a few of these
Vizonex d6c10a7
Ensure MultiDict_Del throws exception when key not found
Vizonex 3d2e83a
add test_del
Vizonex 1a8e629
Merge branch 'capi' of https://github.com/Vizonex/multidict into capi
Vizonex c533610
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 96d1b96
small fixes
Vizonex 9b34eef
almost screwed up thanks to precommit
Vizonex 5927152
Merge branch 'capi' of https://github.com/Vizonex/multidict into capi
Vizonex 98f0144
run reformatter
Vizonex b7208da
add few more tests if I haven't yet done so
Vizonex 1e97e03
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 756e331
use precommit suggestions
Vizonex a9ec875
revert
Vizonex b4239ac
whoops I forgot to remove
Vizonex 2eb9032
mypy fixes
Vizonex 3bb5a74
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 04c2f83
Merge branch 'capi' into capi
asvetlov 3b03439
all tests added we can begin debugging soon...
Vizonex 164be59
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] da32a5e
ALL OF THEM WORK!!!!
Vizonex d691d6d
Merge branch 'capi' of https://github.com/Vizonex/multidict into capi
Vizonex 1a56fc5
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 0c73888
reformat incase I haven't already done so
Vizonex 8f94d17
Merge branch 'capi' of https://github.com/Vizonex/multidict into capi
Vizonex File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Added MultiDict Functions to C-API -- by ``@Vizonex``. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have two options here.
import multidict, include_path=multidict.__path__as I did intestcapi/setup.py__path__;pathlibusage is redundant hereThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@asvetlov There was an issue when I tried compiling it but it may have been a configuration problem on my end so met let me go back and revert this change.