Skip to content

cibuildwheel: remove useless pp* skip selector#1283

Open
justeph wants to merge 1 commit intoaio-libs:masterfrom
justeph:remove-useless-skip-selector
Open

cibuildwheel: remove useless pp* skip selector#1283
justeph wants to merge 1 commit intoaio-libs:masterfrom
justeph:remove-useless-skip-selector

Conversation

@justeph
Copy link
Contributor

@justeph justeph commented Jan 7, 2026

What do these changes do?

Since cibuildwheel 3.0.0 pypy builds are no longer enabled by default 1. We can remove the skip selector. This will also fix the following warning during build:

Warning: cibuildwheel: Invalid skip selector: 'pp*'. This selector matches a group that wasn't enabled. Enable it using the `enable` option or remove this selector. This selector will have no effect.

Are there changes in behavior for the user?

No changes for end user

Since cibuildwheel 3.0.0 pypy builds are no longer enabled by default
[1]. We can remove the skip selector. This will also fix the following
warning during build:

Warning: cibuildwheel: Invalid skip selector: 'pp*'. This selector matches a group that wasn't enabled. Enable it using the `enable` option or remove this selector. This selector will have no effect.

[1]: https://cibuildwheel.pypa.io/en/stable/changelog/#v300

Signed-off-by: Julien Stephan <jstephan@baylibre.com>
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 7, 2026

Merging this PR will not alter performance

Summary

✅ 245 untouched benchmarks


Comparing justeph:remove-useless-skip-selector (bc226f4) with master (e8bf2ad)

Open in CodSpeed

Copy link
Contributor

@Vizonex Vizonex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that mypy is throwing a fit at the moment, I'll brainstorm a fix tomorrow if I feel motivated to fix the linting otherwise someone else might come in and offer suggestions, other than that, I approve of this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants