Open
Conversation
…chani into feature/ipickering/add-ani-1xnr
…chani into feature/ipickering/add-ani-1xnr
Contributor
Author
|
@JMorado I've cherry picked one of your commits so that you show up as co-author of the PR. I'm still not sure about the model however, the forces seem logical, but the energies are very strange. I thought that maybe since the model was trained with PBC, with VASP? or something like that, maybe you used some approximation in the basis set/level of theory that shifts all the energies. I've calculated the same molecule with orca with BLYP TZVPP and I get a result similar to ANI2x / ANI1x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR superseedes Add ani-1xnr model #653
@JMorado
This PR adds support for ANI-1xnr.
I wanted to double check what was the level of theory this model was trained on (docstring says BLYP-TZV2P) since I'm getting "strange" energy results. The absolute energy values are significantly different from 1x and 2x. Is this normal?
For example for the following molecule:
The energy is around -34 Ha, but it is around -170 Ha for 1x and 2x. The atomic self energies are also significantly different.
If this looks good to you, you can add a commit so the PR is shared, and I will merge (I have given you write-access to the repo, so you should be able to do this, no problem).
Note that the actual model used in the repo now lives on https://huggingface.co/roitberg-group/ani1xnr since the neurochem format is a pain, so I converted all models to pytorch state dicts