Set the debezium API version to the latest 3.4.1#72823
Set the debezium API version to the latest 3.4.1#72823rodireich merged 4 commits intosource-postgres/bulk-cdkfrom
Conversation
|
Note 📝 PR Converted to Draft More info...Thank you for creating this PR. As a policy to protect our engineers' time, Airbyte requires all PRs to be created first in draft status. Your PR has been automatically converted to draft status in respect for this policy. As soon as your PR is ready for formal review, you can proceed to convert the PR to "ready for review" status by clicking the "Ready for review" button at the bottom of the PR page. To skip draft status in future PRs, please include |
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksPR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
📚 Show Repo GuidanceHelpful Resources
|
|
Note Detected that there are differences in the Gradle dependencies. |
|
Gradle dependencies report |
| implementation 'com.azure:azure-identity:1.17.0' | ||
|
|
||
| api platform('io.debezium:debezium-bom:3.4.1.Final') | ||
| // version specified by the debezium bom dependency in the cdc toolkit |
|
/ai-review
Reviewing PR for connector safety and quality.
|
|
Starting AI PR review for PR #72823. Evaluating connector safety and quality gates. Session: https://app.devin.ai/sessions/86ff650941334419944dd33d2350f761 |
AI PR Review ReportReview Action: REQUEST CHANGES
🔧 Remediation RequiredRequired ActionsGate 1 (CI/Tests) - FAIL: The CI failures appear to be unrelated to this PR's changes:
Recommended remediation:
Gate 5 (Validation) - UNKNOWN: No pre-release validation evidence found. This is a Debezium version upgrade that could affect CDC behavior. Consider running 📋 PR Details & EligibilityConnector & PR InfoConnector(s): Auto-Approve EligibilityEligible: No Review Action DetailsREQUEST CHANGES - Submitted PR review requesting changes due to failing Gate 1 (CI/Tests). Note that the CI failures appear to be pre-existing CDK issues and infrastructure problems, not caused by this PR's changes.
🔍 Gate Evaluation DetailsGate-by-Gate Analysis
Gate 1 Details (CI/Tests)Failed Checks:
Root Cause Analysis:
Gate 2 Details (Security)No security-sensitive keywords detected in the diff. The change only adds a Debezium BOM version override. Gate 3 Details (Safety/Reversibility)No breaking change patterns detected. The change is additive (adding a BOM override). Gate 4 Details (Operational Risk)No operational risk patterns detected. No changes to rate limits, retries, timeouts, or pagination. Gate 5 Details (Pre-Release Validation)
Gate 6 Details (PR Quality)PR description is present and explains:
📚 Evidence ConsultedEvidence
Diff Analysis+
+ api platform('io.debezium:debezium-bom:3.4.1.Final')The change adds a single line to override the Debezium BOM version to 3.4.1.Final in the source-postgres connector's build.gradle. ❓ How to RespondProviding Context or JustificationYou can add explanations that the bot will see on the next review: Option 1: PR Description (recommended) ## AI PR Review Justification
### Gate 1 (CI/Tests)
[Your explanation here - e.g., "CI failures are pre-existing issues unrelated to this PR"]
### Gate 5 (Pre-Release Validation)
[Your explanation here - e.g., "This change has been tested locally with X"]Option 2: PR Comment After adding your response, re-run Note: For Gate 1, if the CI failures are truly unrelated to your changes, a maintainer may need to help resolve the underlying issues or approve the PR manually. For Gate 5, consider running |
![octavia-bot[bot]](https://avatars.githubusercontent.com/in/217399?s=60&v=4){kind=small}
|
/ai-review
Reviewing PR for connector safety and quality.
|
|
Starting AI PR review for PR #72823. Evaluating connector safety and quality gates. Session: https://app.devin.ai/sessions/daf17848f969413e86d1f3fb56a17176 |
AI PR Review ReportReview Action: REQUEST CHANGES
🔧 Remediation RequiredRequired ActionsGate 1 (CI/Tests) - FAIL: Both Lint and Test checks failed due to pre-existing CDK deprecation warnings being treated as errors with
These failures are NOT caused by this PR's changes - they exist in the base branch ( Recommended remediation:
Gate 5 (Validation) - UNKNOWN: No pre-release validation evidence found. This is a Debezium version upgrade (to 3.4.1.Final) that could affect CDC behavior. Consider running 📋 PR Details & EligibilityConnector & PR InfoConnector(s): Auto-Approve EligibilityEligible: No Review Action DetailsREQUEST CHANGES - Submitted PR review requesting changes due to failing Gate 1 (CI/Tests). Note that the CI failures are caused by pre-existing CDK deprecation warnings in the base branch, not by this PR's changes.
🔍 Gate Evaluation DetailsGate-by-Gate Analysis
Gate 1 Details (CI/Tests)Failed Checks:
Root Cause Analysis: Both failures are caused by the same issue: Kotlin deprecation warnings being treated as errors with This is a pre-existing issue in the CDK test fixtures, not caused by this PR's changes. Gate 2 Details (Security)No security-sensitive keywords detected in the diff. The change only adds a Debezium BOM version override. Gate 3 Details (Safety/Reversibility)No breaking change patterns detected. The change is additive (adding a BOM override). Gate 4 Details (Operational Risk)No operational risk patterns detected. No changes to rate limits, retries, timeouts, or pagination. Gate 5 Details (Pre-Release Validation)
Gate 6 Details (PR Quality)PR description is present and explains:
Note: There's a reviewer comment about a stale comment in the code that should be addressed. 📚 Evidence ConsultedEvidence
Diff Analysis- // version specified by the debezium bom dependency in the cdc toolkit
+
+ api platform('io.debezium:debezium-bom:3.4.1.Final')
+The change:
❓ How to RespondProviding Context or JustificationYou can add explanations that the bot will see on the next review: Option 1: PR Description (recommended) ## AI PR Review Justification
### Gate 1 (CI/Tests)
[Your explanation here - e.g., "CI failures are pre-existing issues in the base branch"]
### Gate 5 (Pre-Release Validation)
[Your explanation here - e.g., "This change has been tested locally with X"]Option 2: PR Comment After adding your response, re-run Note: For Gate 1, since the CI failures are pre-existing issues in the base branch, a maintainer may need to:
For Gate 5, consider running |
| base.conn.use { conn -> | ||
| base.conn.use { | ||
| if (dbNumWraparound(base.conn) > 0) { |
There was a problem hiding this comment.
This feels a little weird. Can we use conn or it on line 31 instead?
mwbayley
left a comment
mwbayley
left a comment
There was a problem hiding this comment.
approved modulo one nit
3 participants
Override the API version of debezium in postgres only - set to the latest 3.4.1.Final
This pulls in debezium-connector-postgres ver 3.4.1.Final as well
and org.postgresql:postgresql:42.7.7
That's the version debezium natively pulled so we don't have a mismatch between pg jdbc driver and debezium libraries.