Add basic support for deleting acf fields#270
Open
apandichi wants to merge 2 commits intoairesvsg:masterfrom
Open
Add basic support for deleting acf fields#270apandichi wants to merge 2 commits intoairesvsg:masterfrom
apandichi wants to merge 2 commits intoairesvsg:masterfrom
Conversation
airesvsg
reviewed
Sep 13, 2018
| } | ||
|
|
||
| public function delete_item( $request ) { | ||
| $fields = $this->acf->get_fields( $request )['acf']; |
Owner
There was a problem hiding this comment.
Please, check before to access.
$fields = $this->acf->get_fields( $request );
if ( $fields && isset( $fielsd['acf'] ) ) {
$fields = $fields['acf'];
}
Owner
|
Hi @apandichi, |
Author
|
@airesvsg Does this PR have any chance of getting merged and released soon? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very naive implementation that might fix #269
It applies only to v3 of the API, and it does not take into account the "edit_in_rest" setting.
There could be other things that I have missed... But it's a start, I hope!