Open
Conversation
ajay-prabhakar
requested changes
Dec 27, 2019
Owner
ajay-prabhakar
left a comment
ajay-prabhakar
left a comment
There was a problem hiding this comment.
Hello, @robustTechie thanks for the PR and good work I suggested some changes here please go on it
app/src/main/java/com/example/android/codeforces/Activities/ProfileActivity.java
Show resolved
Hide resolved
| } | ||
| } | ||
| public void logOut(){ | ||
| Intent intent = new Intent(this,MainActivity.class); |
Owner
There was a problem hiding this comment.
If we give the direct intent then when we press the back button then it will come back the previous activity so, App will crashes by taking 2 usernames avoid that behaviour
Owner
|
we have the plugin called spotless it will automatically make some better code by running the command |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #46
Changes: Added the logout button in view profile page, after pressing user will go back to new handler search.(Files Changed - ProfileActivity.java, activity_profile.xml, HomeFeedActivity)
Screenshots of the change:
